fix(media): sanitize animated image uploads#2524
Merged
Merged
Conversation
atishpatel
marked this pull request as ready for review
July 23, 2026 14:33
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
atishpatel
force-pushed
the
atish/sanitize-animated-images
branch
from
July 23, 2026 15:24
f155646 to
c8cfd93
Compare
tlongwell-block
approved these changes
Jul 23, 2026
tlongwell-block
pushed a commit
that referenced
this pull request
Jul 23, 2026
…hardening * origin/main: feat(dev): add `just production` recipe targeting the production relay (#2572) chore: Omit the Model control when an optional-model harness has nothing to select (#2262) fix(ci): stop moving protected Sprig rolling tag (#2221) fix(media): sanitize animated image uploads (#2524) fix(desktop): populate team instructions when opening the edit team dialog (#2565) feat(desktop): add drag-to-reorder for community rail (#2549)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Animated PNG and WebP uploads preserved animation by bypassing desktop re-encoding, but that also preserved metadata rejected by the relay. Mobile rejected GIF, APNG, and animated WebP uploads instead of safely preparing them.
What
Risk Assessment
Medium — this changes upload preprocessing for animated images on desktop and mobile. Static image handling is unchanged, and the relay remains the final policy authority.
References
just dev: metadata-bearing APNG and WebP fixtures were rejected by the local relay with 422 before sanitization; sanitized APNG, WebP, and GIF uploads succeededba16043e…), WebP (75f510fd…), and GIF (80f4533b…)just cibuzz-agentcancellation regression passed after it failed once during the parallel pre-push hookjust devTauri process was not addressable by the macOS automation bridgeReview follow-up — 2026-07-23
Codex review found six actionable edge cases, all fixed:
A final Codex review found no remaining actionable correctness issues.
just cipassed again after rebasing onto the latestmain.Generated with Codex